Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove confusing slurm-related code #9417

Merged
merged 1 commit into from
May 24, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented May 23, 2024

Ticket

Description

This code clones dev-scripts to get slurmcluster. Unfortunately there are two things named slurmcluster and it doesn't need the one (the gcp slurm tests run make -C tools/slurm slurmcluster which lives entirely within the repo).

Test Plan

Needs no tests.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@stoksc stoksc requested a review from eecsliu May 23, 2024 22:03
@stoksc stoksc requested a review from a team as a code owner May 23, 2024 22:03
@stoksc stoksc requested a review from dannysauer May 23, 2024 22:03
@cla-bot cla-bot bot added the cla-signed label May 23, 2024
Copy link

netlify bot commented May 23, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit e28944c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/664fbd1bf882420008177ad3
😎 Deploy Preview https://deploy-preview-9417--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.61%. Comparing base (3cbe805) to head (e28944c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9417   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files        1233     1233           
  Lines      158958   158958           
  Branches     2778     2777    -1     
=======================================
  Hits        77282    77282           
  Misses      81502    81502           
  Partials      174      174           
Flag Coverage Δ
backend 42.17% <ø> (ø)
harness 64.02% <ø> (ø)
web 44.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@eecsliu eecsliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less confusion is more better.

@stoksc
Copy link
Contributor Author

stoksc commented May 24, 2024

gonna, as usual, land over unrelated failures

@stoksc stoksc merged commit 3dfb9ec into main May 24, 2024
86 of 101 checks passed
@stoksc stoksc deleted the chore/stoksc/remove-unnecessary-slurm-code branch May 24, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants