Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: Framework splitting #9405

Merged
merged 1 commit into from
May 22, 2024
Merged

revert: Framework splitting #9405

merged 1 commit into from
May 22, 2024

Conversation

billboggs
Copy link
Contributor

@billboggs billboggs commented May 22, 2024 •
edited by jira bot
Loading

This reverts commit a96cafd.

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@billboggs billboggs requested review from a team as code owners May 22, 2024 01:17
@cla-bot cla-bot bot added the cla-signed label May 22, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label May 22, 2024
@determined-ci determined-ci requested a review from a team May 22, 2024 01:17
@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 139f741
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/664d47b97426200008f4e855
😎 Deploy Preview https://deploy-preview-9405--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@billboggs billboggs changed the title revert: Framework splitting #9318 revert: Framework splitting May 22, 2024
@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 48.57%. Comparing base (6ff8eb7) to head (139f741).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9405      +/-   ##
==========================================
- Coverage   48.59%   48.57%   -0.02%     
==========================================
  Files        1234     1234              
  Lines      158840   158837       -3     
  Branches     2779     2778       -1     
==========================================
- Hits        77186    77153      -33     
- Misses      81479    81509      +30     
  Partials      175      175
Flag Coverage Δ
backend 42.07% <ø> (-0.06%) ⬇️
harness 64.02% <93.93%> (-0.02%) ⬇️
web 44.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/exec/launch.py 78.00% <ø> (ø)
...ness/tests/experiment/keras/test_tf_keras_trial.py 98.75% <100.00%> (-0.09%) ⬇️
harness/tests/launch/test_launch.py 100.00% <100.00%> (ø)
harness/determined/core/_profiler.py 57.56% <0.00%> (ø)
harness/tests/experiment/test_local.py 96.66% <96.66%> (ø)

... and 12 files with indirect coverage changes

dannysauer
dannysauer approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

tara-det-ai
tara-det-ai approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billboggs billboggs enabled auto-merge (squash) May 22, 2024 15:23
@billboggs billboggs disabled auto-merge May 22, 2024 15:24
@billboggs billboggs merged commit 4af9bfc into main May 22, 2024
88 of 105 checks passed
@billboggs billboggs deleted the revert-9318 branch May 22, 2024 16:08
MikhailKardash added a commit that referenced this pull request May 30, 2024
@MikhailKardash
Revert "revert: Framework splitting (#9405)"
82bb711 
This reverts commit 4af9bfc.
@MikhailKardash MikhailKardash mentioned this pull request May 30, 2024
Merged
4 tasks
MikhailKardash added a commit that referenced this pull request Jun 6, 2024
@MikhailKardash
Revert "revert: Framework splitting (#9405)"
55fd076 
This reverts commit 4af9bfc.
MikhailKardash added a commit that referenced this pull request Jun 12, 2024
@MikhailKardash
feat: Framework Splitting and Bumpenvs (#9457)
8e9067b 
* Revert #9405
* Bumpenvs for NGC+ images
* Various fixes for slurm builds and runs
* Docs table changes
* Drop --cuda and --cpu from hpc launcher in CI
* Adds afw efs test update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannysauer dannysauer dannysauer approved these changes

@stoksc stoksc stoksc approved these changes

@keita-determined keita-determined keita-determined approved these changes

@tara-det-ai tara-det-ai tara-det-ai approved these changes

@davidfluck-hpe davidfluck-hpe davidfluck-hpe approved these changes

@johnkim-det johnkim-det Awaiting requested review from johnkim-det johnkim-det is a code owner automatically assigned from determined-ai/web

@salonig23 salonig23 Awaiting requested review from salonig23 salonig23 is a code owner automatically assigned from determined-ai/backend

@MikhailKardash MikhailKardash Awaiting requested review from MikhailKardash MikhailKardash is a code owner automatically assigned from determined-ai/model-dev

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@billboggs @dannysauer @stoksc @keita-determined @tara-det-ai @davidfluck-hpe @determined-ci