chore: check non-multiples of slots per pod for kubernetes rm [MD-403] #9393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9393 +/- ##
==========================================
+ Coverage 48.99% 49.02% +0.02%
==========================================
Files 1235 1235
Lines 160191 160199 +8
Branches 2780 2780
==========================================
+ Hits 78482 78533 +51
+ Misses 81534 81491 -43
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui canceled.
|
stoksc
approved these changes
May 20, 2024
| @@ -736,6 +736,55 @@ func TestROCmPodsService(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestValidateResources(t *testing.T) { | |||
| @@ -269,6 +269,10 @@ func (k *kubernetesResourcePool) ValidateResources( | |||
| k.reschedule = true | |||
|
|
|||
| fulfillable := k.maxSlotsPerPod >= msg.Slots | |||
|
|
|||
| if !msg.IsSingleNode { | |||
There was a problem hiding this comment.
nit: it'd be nice to have this return specific errors rather than the caller trying to describe what could possibly go wrong in this function.
and then assignResources could reuse the error defs, too.
There was a problem hiding this comment.
yeah, i thought about this but didn't want to get too carried away with refactors. anyway, good call, done.
azhou-determined
force-pushed
the
krm-validate-slots
branch
4 times, most recently
from
12e5668
to
835a281
Compare
azhou-determined
force-pushed
the
krm-validate-slots
branch
from
835a281
to
969377b
Compare
azhou-determined
force-pushed
the
krm-validate-slots
branch
from
e0ec4e5
to
3280d1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Error out earlier for Kubernetes clusters when slots requested are not a multiple of
max_slots_per_podDescription
Test Plan
On a kubernetes cluster with
max_slots_per_podconfigured as > 1, submit an experiment withslots_per_trialas a non-multiple ofmax_slots_per_pod(i.e.slots_per_trial=2,max_slots_per_pod=3). experiment should error out upon creation.Checklist
docs/release-notes/.See Release Note for details.