test: More Page Models for Experiment Tracking [INFENG-686] #9367
Conversation
…NFENG-457/experiement-list-page-models-continued
… into jcom/INFENG-694/refactor-e2e-react-dropdown
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9367 +/- ##
==========================================
- Coverage 45.28% 38.71% -6.58%
==========================================
Files 1227 903 -324
Lines 154048 114229 -39819
Branches 2404 2404
==========================================
- Hits 69767 44221 -25546
+ Misses 84089 69816 -14273
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| <Select | ||
| autoFocus | ||
| data-test="columnName" |
There was a problem hiding this comment.
What is the difference between data-test-id, data-test-component, and data-test? Probably more important: how would someone new to these tests know which one to add?
I know we talked about component before, but the more I think about this the less I like having multiple types of these data-test** attributes. What is the benefit of differentiating the key instead of the value, and is that benefit worth having to teach everyone who writes these tests the difference?
There was a problem hiding this comment.
yeah i wanted to add this to the readme.
data-test-component -> top level id for components
data-test -> test hooks for sub components
data-testid -> i'm using it for the first time here. it's for dynamic data
As an example, ColumnPickerTab gets data-test-component="columnPickerTab" at it's top level. rows inside the column picker all have data-test="row" . Each row will have a data-test-id="${testid}", which is equal to col.column in production code. It's just the name of the column. It's much easier than grabbing, say, the nth row.
There was a problem hiding this comment.
it's possible to use all three keys in one element. that's why we need many
| readonly defaultSelector = '[data-test-component="FilterGroup"]'; | ||
|
|
||
| #childrenSelector = '[data-test="children"]'; | ||
| #notNestedSelector = `:not(${this.#childrenSelector} *)`; |
There was a problem hiding this comment.
should these be private/readonly?
There was a problem hiding this comment.
yes, let me add readonly. theyre already private
JComins000
changed the title
JComins000
deleted the
jcom/INFENG-457/experiement-list-page-models-continued
branch
Ticket
INFENG-686
Description
Test Plan
Checklist
docs/release-notes/.See Release Note for details.