Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: report test results from harness tests #9366

Merged
merged 7 commits into from
May 15, 2024
Merged

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented May 14, 2024

Ticket

https://hpe-aiatscale.atlassian.net/browse/MD-343

Description

generate and store test results from harness unit tests, det deploy, and cli tests
eg https://app.circleci.com/pipelines/github/determined-ai/determined/55623/workflows/bbe252fd-4ec2-4d3a-ba23-5b5be5fcc6e7/jobs/2570219/tests

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 14, 2024
Copy link

netlify bot commented May 14, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit dd7d61f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66450989de9f9300082d6412

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.28%. Comparing base (93c8d81) to head (dd7d61f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9366      +/-   ##
==========================================
- Coverage   45.29%   45.28%   -0.02%     
==========================================
  Files        1227     1227              
  Lines      154095   154095              
  Branches     2404     2404              
==========================================
- Hits        69805    69775      -30     
- Misses      84098    84128      +30     
  Partials      192      192              
Flag Coverage Δ
backend 41.75% <ø> (-0.06%) ⬇️
harness 64.09% <ø> (ø)
web 36.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@hamidzr hamidzr self-assigned this May 14, 2024
@hamidzr hamidzr marked this pull request as ready for review May 15, 2024 15:16
@hamidzr hamidzr requested review from a team as code owners May 15, 2024 15:16
Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place we should be able to see the test results?

@hamidzr
Copy link
Contributor Author

hamidzr commented May 15, 2024

Is there a place we should be able to see the test results?

I have a link in the pr description. they show up in the ci interface. they're not really readable there if they're all passing which is why I have https://hpe-aiatscale.atlassian.net/browse/INFENG-633

Screenshot 2024-05-15 at 13 05 07

@hamidzr hamidzr assigned gt2345 and unassigned hamidzr May 15, 2024
@hamidzr hamidzr requested a review from gt2345 May 15, 2024 18:16
Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the explanation

@hamidzr hamidzr enabled auto-merge (squash) May 15, 2024 19:31
@hamidzr hamidzr assigned hamidzr and unassigned gt2345 May 15, 2024
@hamidzr hamidzr merged commit d38e2e0 into main May 15, 2024
80 of 96 checks passed
@hamidzr hamidzr deleted the hz-harness-resutls branch May 15, 2024 19:37
kkunapuli pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants