-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: report test results from harness tests #9366
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9366 +/- ##
==========================================
- Coverage 45.29% 45.28% -0.02%
==========================================
Files 1227 1227
Lines 154095 154095
Branches 2404 2404
==========================================
- Hits 69805 69775 -30
- Misses 84098 84128 +30
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more. |
164742f
to
8bffa80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a place we should be able to see the test results?
I have a link in the pr description. they show up in the ci interface. they're not really readable there if they're all passing which is why I have https://hpe-aiatscale.atlassian.net/browse/INFENG-633 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the explanation
Ticket
https://hpe-aiatscale.atlassian.net/browse/MD-343
Description
generate and store test results from harness unit tests, det deploy, and cli tests
eg https://app.circleci.com/pipelines/github/determined-ai/determined/55623/workflows/bbe252fd-4ec2-4d3a-ba23-5b5be5fcc6e7/jobs/2570219/tests
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.