Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove step for authenticated master session check to use standard script #9339

Merged
merged 1 commit into from
May 8, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented May 8, 2024

chore: remove step for authenticated master session check to use standard script

Ticket

No ticket.

Description

test-e2e-gke-shared-cluster adds a step that waits for the master connection using an authenticated determined session, verifying that valid authenticated requests during the test runs are expected to succeed.
Remove this step to use the standard script that tests the master connection with an unauth session, as this achieves the main goal of the step, which is to ensure that the master is accessible prior to running test cases.

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@amandavialva01 amandavialva01 requested a review from a team as a code owner May 8, 2024 18:41
@cla-bot cla-bot bot added the cla-signed label May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit e85ba1b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663bd254c855d100082fde04

Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment. also, why doesn't this issue have a ticket?

@amandavialva01
Copy link
Contributor Author

one comment. also, why doesn't this issue have a ticket?

This was inquired about in a Slack thread. Since it's a quick change, I just made a PR!

@amandavialva01 amandavialva01 merged commit c0fdaa9 into main May 8, 2024
81 of 95 checks passed
@amandavialva01 amandavialva01 deleted the amanda/testWaitForMaster branch May 8, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants