Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing setuptools to win cli tests #9336

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented May 8, 2024

Ticket

https://hpe-aiatscale.atlassian.net/issues/RM-260?filter=10316

Description

why now? a pip version change?

Test Plan

tests pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 651178e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663bb7f686639a0008dd3e0f

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.56%. Comparing base (492ef57) to head (651178e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9336      +/-   ##
==========================================
- Coverage   44.58%   44.56%   -0.02%     
==========================================
  Files        1275     1275              
  Lines      156478   156478              
  Branches     2449     2449              
==========================================
- Hits        69767    69738      -29     
- Misses      86471    86500      +29     
  Partials      240      240              
Flag Coverage Δ
backend 41.70% <ø> (-0.06%) ⬇️
harness 64.09% <ø> (ø)
web 34.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@hamidzr hamidzr marked this pull request as ready for review May 8, 2024 17:09
@hamidzr hamidzr requested a review from a team as a code owner May 8, 2024 17:09
@hamidzr hamidzr requested a review from dannysauer May 8, 2024 17:09
@hamidzr hamidzr changed the title wip: win cli tests failing chore: address win cli tests failing May 8, 2024
@hamidzr hamidzr changed the title chore: address win cli tests failing chore: add missing setuptools to win cli tests May 8, 2024
description: "Help with debugging Python and pip related issues."
steps:
# keep it a single line to avoid adding ci overhead. each step is about 5s.
- run: python --version; pip --version; pip list; sh -c "pip check || true"
Copy link
Contributor

@JComins000 JComins000 May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try using block scalar syntax?
https://yaml-multiline.info/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this

- run: |
    git add --all
    git commit -am "a commit message"
    git push

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 and "single step" would be more accurate for the comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id be cool with removing the comment altogether. let the syntax serve as an example. either way is cool

@hamidzr hamidzr merged commit cc82cc9 into main May 8, 2024
84 of 97 checks passed
@hamidzr hamidzr deleted the hz-seutptools-win branch May 8, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants