-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing setuptools to win cli tests #9336
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9336 +/- ##
==========================================
- Coverage 44.58% 44.56% -0.02%
==========================================
Files 1275 1275
Lines 156478 156478
Branches 2449 2449
==========================================
- Hits 69767 69738 -29
- Misses 86471 86500 +29
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. |
.circleci/real_config.yml
Outdated
description: "Help with debugging Python and pip related issues." | ||
steps: | ||
# keep it a single line to avoid adding ci overhead. each step is about 5s. | ||
- run: python --version; pip --version; pip list; sh -c "pip check || true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you try using block scalar syntax?
https://yaml-multiline.info/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this
- run: |
git add --all
git commit -am "a commit message"
git push
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 and "single step" would be more accurate for the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id be cool with removing the comment altogether. let the syntax serve as an example. either way is cool
Ticket
https://hpe-aiatscale.atlassian.net/issues/RM-260?filter=10316
Description
why now? a pip version change?
Test Plan
tests pass
Checklist
docs/release-notes/
.See Release Note for details.