Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip a flaky test [ET-233, ET-178] #9324

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented May 7, 2024

Ticket

[ET-233, ET-178]

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@JComins000 JComins000 requested a review from a team as a code owner May 7, 2024 16:08
@cla-bot cla-bot bot added the cla-signed label May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit a7dbc91
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663a51ed469aff0008529c75
😎 Deploy Preview https://deploy-preview-9324--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what I'm approving, but the words match the description. :D

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.94%. Comparing base (5b73dc4) to head (a7dbc91).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9324      +/-   ##
==========================================
- Coverage   44.60%   37.94%   -6.66%     
==========================================
  Files        1275      951     -324     
  Lines      156385   116563   -39822     
  Branches     2450     2450              
==========================================
- Hits        69756    44231   -25525     
+ Misses      86389    72092   -14297     
  Partials      240      240              
Flag Coverage Δ
harness ?
web 34.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

@JComins000 JComins000 merged commit 1779060 into main May 7, 2024
87 of 100 checks passed
@JComins000 JComins000 deleted the jcom/INFENG/skip-a-test branch May 7, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants