Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /template/rename to patch template name #9320

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented May 6, 2024

Ticket

MD-380

Description

Create a new endpoint /template/rename for patching template name. Duplicated name will be rejected.

Test Plan

PATCH /api/v1/template/rename takes old_name and new_name
Test the API with duplicated name and valid name.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@gt2345 gt2345 requested a review from a team as a code owner May 6, 2024 22:17
@gt2345 gt2345 requested a review from hamidzr May 6, 2024 22:17
@cla-bot cla-bot bot added the cla-signed label May 6, 2024
@gt2345 gt2345 requested review from kkunapuli and removed request for hamidzr May 6, 2024 22:17
Copy link

netlify bot commented May 6, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit e9ec87d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663bf6a09d54630008476acc
😎 Deploy Preview https://deploy-preview-9320--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 61.22449% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 45.15%. Comparing base (cc82cc9) to head (e9ec87d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9320      +/-   ##
==========================================
+ Coverage   45.13%   45.15%   +0.02%     
==========================================
  Files        1230     1230              
  Lines      154523   154572      +49     
  Branches     2405     2404       -1     
==========================================
+ Hits        69740    69798      +58     
+ Misses      84588    84579       -9     
  Partials      195      195              
Flag Coverage Δ
backend 41.78% <86.36%> (+0.07%) ⬆️
harness 64.07% <40.74%> (-0.02%) ⬇️
web 36.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/templates/api.go 73.20% <86.36%> (+1.54%) ⬆️
harness/determined/common/api/bindings.py 40.21% <40.74%> (+<0.01%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@kkunapuli kkunapuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - great work!

@gt2345 gt2345 merged commit df0b7f9 into main May 9, 2024
83 of 96 checks passed
@gt2345 gt2345 deleted the gt/380-template-renaming branch May 9, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants