Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for configuring the shared_fs mount path in genai #9317

Merged
merged 1 commit into from
May 7, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented May 6, 2024

Ticket

GAS-14

Description

Allows us to pass a mount path for the shared_fs drive in genai. This makes it possible to use shared_fs for checkpoints and for datasets without necessarily using the same disk.

Test Plan

No need to test in release party. The GenAI team is testing separately.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@tayritenour tayritenour requested a review from a team as a code owner May 6, 2024 21:07
@tayritenour tayritenour requested a review from kkunapuli May 6, 2024 21:07
@cla-bot cla-bot bot added the cla-signed label May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 49063bc
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6639468779e6750008367945
😎 Deploy Preview https://deploy-preview-9317--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.63%. Comparing base (a76c549) to head (49063bc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9317   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files        1275     1275           
  Lines      156285   156286    +1     
  Branches     2450     2449    -1     
=======================================
+ Hits        69757    69758    +1     
  Misses      86288    86288           
  Partials      240      240           
Flag Coverage Δ
backend 41.82% <ø> (ø)
harness 64.10% <100.00%> (+<0.01%) ⬆️
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/aws/cli.py 16.86% <ø> (ø)
harness/determined/deploy/aws/constants.py 100.00% <100.00%> (ø)
...ess/determined/deploy/aws/deployment_types/base.py 39.74% <ø> (ø)

... and 4 files with indirect coverage changes

@tayritenour tayritenour enabled auto-merge (squash) May 6, 2024 22:38
@tayritenour tayritenour merged commit 6fb62ad into main May 7, 2024
87 of 100 checks passed
@tayritenour tayritenour deleted the GAS-14 branch May 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants