Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: send job level failure slack alerts #9315

Merged
merged 11 commits into from
May 8, 2024
Merged

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented May 6, 2024

Ticket

Description

Send alerts for every job on circleci. Previous alerts did not include every job.

Don't include the last committer since this has often gotten random. Instead plan to include teams that own each job in the near future.

Test Plan

Tested by sending alerts here

https://app.circleci.com/pipelines/github/determined-ai/determined/55231/workflows/15dbb0ff-a11a-4676-a5a0-a0f5e71c44b7

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 3761df4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663a403ca745c200088a61f9

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.02%. Comparing base (a76c549) to head (7d5f211).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9315      +/-   ##
==========================================
- Coverage   44.63%   35.02%   -9.62%     
==========================================
  Files        1275      464     -811     
  Lines      156285    68591   -87694     
  Branches     2450     2450              
==========================================
- Hits        69757    24022   -45735     
+ Misses      86288    44329   -41959     
  Partials      240      240              
Flag Coverage Δ
harness ?
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 812 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review May 7, 2024 14:55
@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner May 7, 2024 14:55
@NicholasBlaskey NicholasBlaskey merged commit 6e10465 into main May 8, 2024
81 of 94 checks passed
@NicholasBlaskey NicholasBlaskey deleted the send_job_level_alerts branch May 8, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants