-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: send job level failure slack alerts #9315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9315 +/- ##
==========================================
- Coverage 44.63% 35.02% -9.62%
==========================================
Files 1275 464 -811
Lines 156285 68591 -87694
Branches 2450 2450
==========================================
- Hits 69757 24022 -45735
+ Misses 86288 44329 -41959
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. |
loksonarius
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Send alerts for every job on circleci. Previous alerts did not include every job.
Don't include the last committer since this has often gotten random. Instead plan to include teams that own each job in the near future.
Test Plan
Tested by sending alerts here
https://app.circleci.com/pipelines/github/determined-ai/determined/55231/workflows/15dbb0ff-a11a-4676-a5a0-a0f5e71c44b7
Checklist
docs/release-notes/
.See Release Note for details.