Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: store npm log #9311

Merged
merged 1 commit into from
May 3, 2024
Merged

ci: store npm log #9311

merged 1 commit into from
May 3, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented May 3, 2024

Ticket

Description

https://app.circleci.com/pipelines/github/determined-ai/determined/55152/workflows/e5f1c0c8-1717-47ca-a993-6a8d9d3ee279/jobs/2534702/steps is occasionally fail, so store npm log to debug

Test Plan

  • ci pass
  • npm log should be store in test-e2e-react-ee ci job

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 3, 2024
@keita-determined keita-determined marked this pull request as ready for review May 3, 2024 23:38
@keita-determined keita-determined requested a review from a team as a code owner May 3, 2024 23:38
Copy link

netlify bot commented May 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c2e2b28
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663575665972060008b087be

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.62%. Comparing base (f9b96fe) to head (c2e2b28).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9311      +/-   ##
==========================================
+ Coverage   40.78%   44.62%   +3.84%     
==========================================
  Files        1247     1275      +28     
  Lines      154480   156261    +1781     
  Branches     2449     2450       +1     
==========================================
+ Hits        63004    69736    +6732     
+ Misses      91236    86285    -4951     
  Partials      240      240              
Flag Coverage Δ
backend 41.82% <ø> (ø)
harness 64.08% <ø> (+14.70%) ⬆️
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 164 files with indirect coverage changes

@keita-determined keita-determined merged commit 24aaff4 into main May 3, 2024
87 of 101 checks passed
@keita-determined keita-determined deleted the ci/store-npm-log branch May 3, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants