test: experiement list tests [INFENG-457] #9299
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9299 +/- ##
==========================================
+ Coverage 45.13% 46.50% +1.36%
==========================================
Files 1230 743 -487
Lines 154523 106570 -47953
Branches 2405 2404 -1
==========================================
- Hits 69740 49556 -20184
+ Misses 84588 56819 -27769
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. |
JComins000
force-pushed
the
jcom/INFENG-457/experiement-list-tests
branch
from
9feafa1
to
a06e640
Compare
JComins000
force-pushed
the
jcom/INFENG-457/experiement-list-tests
branch
from
a06e640
to
5cc5be7
Compare
| await expect( | ||
| projectDetailsPageSetupTeardown.f_experiemntList.tableActionBar.pwLocator, | ||
| ).toBeVisible(); | ||
| // wait for it to not say "loading experiments..." |
There was a problem hiding this comment.
i'll get to this in a future PR
.circleci/real_config.yml
Outdated
| - run: echo 'export PW_PASSWORD=' >> $BASH_ENV | ||
| - run: echo 'export DET_WEBPACK_PROXY_URL="http://localhost:8082"' >> $BASH_ENV | ||
| - run: echo 'export DET_WEBSOCKET_PROXY_URL="ws://localhost:8082"' >> $BASH_ENV | ||
| # - run: echo 'export PW_DET_PATH="/tmp/venv/bin/det"' >> $BASH_ENV |
There was a problem hiding this comment.
these have moved to playwright context. I thought it might be good to comment the values for now since circle ci hides them. is there any other place we should store them for reference?
There was a problem hiding this comment.
I would just delete them here. Add them to the readme if not there already?
.circleci/real_config.yml
Outdated
| - run: echo 'export PW_PASSWORD=' >> $BASH_ENV | ||
| - run: echo 'export DET_WEBPACK_PROXY_URL="http://localhost:8082"' >> $BASH_ENV | ||
| - run: echo 'export DET_WEBSOCKET_PROXY_URL="ws://localhost:8082"' >> $BASH_ENV | ||
| # - run: echo 'export PW_DET_PATH="/tmp/venv/bin/det"' >> $BASH_ENV |
There was a problem hiding this comment.
I would just delete them here. Add them to the readme if not there already?
webui/react/src/e2e/utils/detCLI.ts
Outdated
| import { execSync } from 'child_process'; | ||
| import path from 'path'; | ||
|
|
||
| if (process.env.PW_DET_PATH === undefined) { |
There was a problem hiding this comment.
Could we have a default of just det or something for running locally for those of us who have det on our $PATH?
There was a problem hiding this comment.
it might not work if you have det in a conda environment. I'll make a default, but you'll probably have to use which det from inside your conda env to get the path
Ticket
INFENG-457
Description
note this is just to get tests on the board. more page models and test scenarios are scoped to other tickets
innerHTMLTest Plan
Checklist
docs/release-notes/.See Release Note for details.