Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update efs-utils install for v2.0 #9297

Merged
merged 1 commit into from
May 3, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented May 2, 2024

Ticket

Description

efs-utils needs cargo to be installed. This updates the genai master build to support it according to the docs here: https://github.com/aws/efs-utils

They recommend:

$ sudo apt-get update
$ sudo apt-get -y install git binutils rustc cargo pkg-config libssl-dev
$ git clone https://github.com/aws/efs-utils
$ cd efs-utils
$ ./build-deb.sh
$ sudo apt-get -y install ./build/amazon-efs-utils*deb

Test Plan

Does not need to be tested in release party

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@tayritenour tayritenour requested a review from a team as a code owner May 2, 2024 22:39
@cla-bot cla-bot bot added the cla-signed label May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 23c68e4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663517bbcbbe8b00081da939

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.62%. Comparing base (f6181ab) to head (23c68e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9297      +/-   ##
==========================================
- Coverage   45.69%   44.62%   -1.07%     
==========================================
  Files         788     1275     +487     
  Lines      108391   156261   +47870     
  Branches     2449     2450       +1     
==========================================
+ Hits        49529    69737   +20208     
- Misses      58622    86284   +27662     
  Partials      240      240              
Flag Coverage Δ
backend 41.82% <ø> (+7.58%) ⬆️
harness 64.09% <ø> (ø)
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 487 files with indirect coverage changes

@tayritenour tayritenour enabled auto-merge (squash) May 2, 2024 23:03
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully up to date on this efs thread

but LGTM

@tayritenour tayritenour force-pushed the genai_efs_dependency_update branch from 4c5bb98 to 23c68e4 Compare May 3, 2024 16:58
@tayritenour tayritenour merged commit 4c314a2 into main May 3, 2024
82 of 96 checks passed
@tayritenour tayritenour deleted the genai_efs_dependency_update branch May 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants