Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update "install on k8s" guide to use helm repo instead of tarball. #9293

Merged
merged 2 commits into from
May 8, 2024
Merged

docs: update "install on k8s" guide to use helm repo instead of tarball. #9293

merged 2 commits into from
May 8, 2024

Conversation

ioga
Copy link
Contributor

@ioga ioga commented May 2, 2024 •
edited by jira bot
Loading

Description

Recommend users to use helm repo instead of downloading our custom tarball.

Test Plan

N/A

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 2, 2024
@determined-ci determined-ci requested a review from a team May 2, 2024 19:28
@determined-ci determined-ci added the documentation Improvements or additions to documentation label May 2, 2024
@netlify Netlify
Copy link

netlify bot commented May 2, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d825693
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6633f1079352700008da4d92

dannysauer
dannysauer approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. Thanks for writing it all up!

tara-det-ai
tara-det-ai approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioga ioga merged commit 2abacb9 into main May 8, 2024
80 of 93 checks passed
@ioga ioga deleted the helm-docs branch May 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannysauer dannysauer dannysauer approved these changes

@tara-det-ai tara-det-ai tara-det-ai approved these changes

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ioga @dannysauer @tara-det-ai @determined-ci