Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip a useTypedParams test case due to flakiness #9287

Merged
merged 1 commit into from
May 2, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented May 1, 2024

Ticket

Description

https://hpe-aiatscale.slack.com/archives/C04C9JXB1C2/p1714588016489469

Test Plan

  • CI should pass
  • src/hooks/useTypedParams.test.tsx > useTypedParams > does not touch params that are not in the codec test case should be skipped

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 1, 2024
@keita-determined keita-determined marked this pull request as ready for review May 1, 2024 23:43
@keita-determined keita-determined requested a review from a team as a code owner May 1, 2024 23:43
Copy link

netlify bot commented May 1, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 586a88d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6632d382d4d25d0008f85684
😎 Deploy Preview https://deploy-preview-9287--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.91%. Comparing base (7a296fa) to head (586a88d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9287      +/-   ##
==========================================
- Coverage   44.58%   37.91%   -6.67%     
==========================================
  Files        1275      951     -324     
  Lines      156216   116428   -39788     
  Branches     2451     2451              
==========================================
- Hits        69650    44146   -25504     
+ Misses      86326    72042   -14284     
  Partials      240      240              
Flag Coverage Δ
harness ?
web 35.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

@keita-determined keita-determined changed the title test: skip a test case due to flakiness test: skip a useTypedParams test case due to flakiness May 1, 2024
@keita-determined keita-determined merged commit a8d05fa into main May 2, 2024
94 of 107 checks passed
@keita-determined keita-determined deleted the test/skip-test branch May 2, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants