test: e2e no floating promises [INFENG-668] #9283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9283 +/- ##
==========================================
- Coverage 44.58% 37.91% -6.67%
==========================================
Files 1275 951 -324
Lines 156216 116426 -39790
Branches 2451 2451
==========================================
- Hits 69650 44146 -25504
+ Misses 86326 72040 -14286
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
|
djanicekpach
approved these changes
May 1, 2024
ashtonG
reviewed
May 1, 2024
| @@ -290,7 +290,7 @@ export class HeadRow extends NamedComponent { | |||
| if (index === null) throw new Error(); | |||
| this.#columnDefs.set(await cell.innerText(), +index); | |||
| } catch { | |||
| Promise.reject( | |||
| await Promise.reject( | |||
There was a problem hiding this comment.
why not just throw the error?
There was a problem hiding this comment.
check again, please!
JComins000
force-pushed
the
jcom/INFENG-668/e2e-no-floating-promises
branch
from
7384881
to
6040a9e
Compare
ashtonG
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
INFENG-668
Description
show linting errors on floating promises
Test Plan
Here's an example of a successful lint
Checklist
docs/release-notes/.See Release Note for details.