Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: flaky user test fix [INFENG-663] #9281

Merged
merged 1 commit into from
May 1, 2024

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented May 1, 2024

Ticket

INFENG-663

Description

honestly we should warn about unawaited promises

fixing this

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@JComins000 JComins000 requested a review from a team as a code owner May 1, 2024 20:22
@cla-bot cla-bot bot added the cla-signed label May 1, 2024
Copy link

netlify bot commented May 1, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c18ad34
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6632a48ccfba5e00087b3f3d
😎 Deploy Preview https://deploy-preview-9281--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.91%. Comparing base (e4c6afe) to head (c18ad34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9281      +/-   ##
==========================================
- Coverage   44.58%   37.91%   -6.67%     
==========================================
  Files        1275      951     -324     
  Lines      156216   116428   -39788     
  Branches     2451     2451              
==========================================
- Hits        69647    44143   -25504     
+ Misses      86329    72045   -14284     
  Partials      240      240              
Flag Coverage Δ
harness ?
web 35.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

@JComins000 JComins000 enabled auto-merge (squash) May 1, 2024 20:24
@JComins000 JComins000 merged commit 7a296fa into main May 1, 2024
86 of 100 checks passed
@JComins000 JComins000 deleted the jcom/INFENG-663/user-test-flaky-on-main branch May 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants