Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide runs in archived experiments #9270

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Apr 30, 2024

Ticket

ET-245

Description

Runs that are part of an archived experiment should be considered archived

Test Plan

Integration tests should pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 30, 2024
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 547a3a5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663252307bad0a0008cf7a91

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.58%. Comparing base (95b5164) to head (547a3a5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9270      +/-   ##
==========================================
- Coverage   44.59%   44.58%   -0.02%     
==========================================
  Files        1273     1273              
  Lines      155832   155832              
  Branches     2438     2439       +1     
==========================================
- Hits        69497    69474      -23     
- Misses      86096    86119      +23     
  Partials      239      239              
Flag Coverage Δ
backend 41.69% <100.00%> (-0.05%) ⬇️
harness 64.05% <ø> (ø)
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/api_runs.go 73.61% <100.00%> (ø)

... and 5 files with indirect coverage changes

@AmanuelAaron AmanuelAaron changed the title fix search runs fix: Hide runs in archived experiments Apr 30, 2024
@AmanuelAaron AmanuelAaron marked this pull request as ready for review April 30, 2024 19:35
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner April 30, 2024 19:35
@AmanuelAaron AmanuelAaron merged commit abcc7b4 into main May 1, 2024
88 of 100 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron/archiving-runs branch May 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants