Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable genai to connect to db over TLS #9260

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore: enable genai to connect to db over TLS #9260

merged 1 commit into from
Apr 29, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented Apr 26, 2024

Ticket

GAS-908

Description

Enables genai to connect to the determined db over TLS when this is enabled in the cluster.

Reference Thread: #3624

Test Plan

Does not need to be validated in release party. The genai team is validating it separately.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 26, 2024
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 4f21969
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/662c3505b2dfa5000821c7fc
😎 Deploy Preview https://deploy-preview-9260--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.71%. Comparing base (95e4257) to head (4f21969).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9260   +/-   ##
=======================================
  Coverage   44.71%   44.71%           
=======================================
  Files        1270     1270           
  Lines      155328   155328           
  Branches     2436     2435    -1     
=======================================
  Hits        69460    69460           
  Misses      85632    85632           
  Partials      236      236           
Flag Coverage Δ
backend 41.65% <ø> (ø)
harness 64.28% <ø> (ø)
web 35.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ioga ioga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tayritenour tayritenour enabled auto-merge (squash) April 29, 2024 18:21
@tayritenour tayritenour merged commit aea83df into main Apr 29, 2024
92 of 104 checks passed
@tayritenour tayritenour deleted the GAS-908 branch April 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants