fix: historical-usage date calculation bug #9257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9257 +/- ##
==========================================
- Coverage 44.71% 38.00% -6.71%
==========================================
Files 1271 947 -324
Lines 155397 115741 -39656
Branches 2436 2437 +1
==========================================
- Hits 69487 43993 -25494
+ Misses 85673 71511 -14162
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
|
keita-determined
force-pushed
the
fix/historical-usage-bug
branch
from
7e2e270
to
5c98f31
Compare
| @@ -53,32 +54,34 @@ const ClusterHistoricalUsageFilters: React.FC<ClusterHistoricalUsageFiltersProps | |||
|
|
|||
| const handleAfterDateSelect = (afterDate: Dayjs | null) => { | |||
| if (!afterDate) return; | |||
| const val = _.cloneDeep(value); | |||
There was a problem hiding this comment.
value from props should not be directly modified.
carolinaecalderon
added
the
to-cherry-pick
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
(cherry picked from commit 8794e42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DET-10249
Description
valueprop was directly modified in calendar onChange handler. That caused unintentional state change.Test Plan
/clusters/historical-usagefromrange too far (more than a year) with group bydayandmonthsstart date cannot be after end dateerror is not shown and correctly call/api/v1/resources/allocation/aggregatedAPIChecklist
docs/release-notes/.See Release Note for details.