Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hew update for chart scroll bug #9210

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Apr 19, 2024

Ticket

ET-42

Description

hew update to get chart scroll fix

Test Plan

  • Select several experiments in the new experiment table to see at least 5 charts in comparison view
  • and scroll up and down without any glitch (see the video in the ticket)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 19, 2024
@keita-determined keita-determined marked this pull request as ready for review April 19, 2024 21:02
@keita-determined keita-determined requested a review from a team as a code owner April 19, 2024 21:02
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ae15d19
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6626a87bfd497c00077cd0a5

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.72%. Comparing base (1b212ae) to head (ae15d19).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9210      +/-   ##
==========================================
- Coverage   44.72%   44.72%   -0.01%     
==========================================
  Files        1266     1266              
  Lines      154770   154770              
  Branches     2438     2433       -5     
==========================================
- Hits        69225    69224       -1     
- Misses      85313    85314       +1     
  Partials      232      232              
Flag Coverage Δ
backend 41.56% <ø> (-0.01%) ⬇️
harness 64.14% <ø> (ø)
web 35.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@keita-determined keita-determined merged commit 3bfc212 into main Apr 22, 2024
84 of 96 checks passed
@keita-determined keita-determined deleted the fix/chart-scroll-bug branch April 22, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants