docs: fix nvidia device plugin link for EKS #9204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use a permalink through a release compared with https://github.com/NVIDIA/k8s-device-plugin/blob/v0.14.5/nvidia-device-plugin.yml colordiff ~/dl/nvidia-device-plugin.yml /tmp/15 41c41 < - image: nvcr.io/nvidia/k8s-device-plugin:v0.14.5 --- > - image: nvcr.io/nvidia/k8s-device-plugin:v0.15.
✅ Deploy Preview for determined-ui canceled.
|
hamidzr
requested review from
a team and
NicholasBlaskey
and removed request for
a team
NicholasBlaskey
approved these changes
Apr 19, 2024
| @@ -206,7 +206,7 @@ command to install the plugin: | |||
| .. code:: bash | |||
|
|
|||
| # Deploy a DaemonSet that enables the GPUs. | |||
| kubectl apply -f https://github.com/raw/NVIDIA/k8s-device-plugin/master/nvidia-device-plugin.yml | |||
| kubectl apply -f https://github.com/raw/NVIDIA/k8s-device-plugin/v0.15.0/deployments/static/nvidia-device-plugin.yml | |||
There was a problem hiding this comment.
Maybe just leave it to use main but update the path?
Does this upgrade often? I wouldn't want us to recommend a really old device plugin. In some sense the link breaking did its job since we updated it and kept it current.
There was a problem hiding this comment.
+1, perhaps https://github.com/raw/NVIDIA/k8s-device-plugin/main/deployments/static/nvidia-device-plugin.yml
|
why didn't the gh automatically request a review from a specific docs team member? different policies for different teams? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use a permalink through a release
compared with https://github.com/NVIDIA/k8s-device-plugin/blob/v0.14.5/nvidia-device-plugin.yml
Ticket
Description
Test Plan
Checklist
docs/release-notes/.See Release Note for details.