ci: fix test-det-deploy-local #9196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
kkunapuli
approved these changes
Apr 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9196 +/- ##
==========================================
- Coverage 44.74% 38.07% -6.67%
==========================================
Files 1264 1086 -178
Lines 154564 140612 -13952
Branches 2439 2439
==========================================
- Hits 69152 53543 -15609
- Misses 85180 86837 +1657
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more. |
djanicekpach
approved these changes
Apr 18, 2024
eecsliu
commented
Apr 18, 2024
.circleci/real_config.yml
Outdated
| branches: | ||
| only: | ||
| - main | ||
| # filters: |
There was a problem hiding this comment.
temporarily commented this out to make sure the test is fixed
eecsliu
force-pushed
the
fix-det-deploy-local
branch
from
32bec06
to
17719cf
Compare
JComins000
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Det deploy local test didn't have the proper dependencies linked, so the test is failing (on main). This just adds
package-and-push-system-localas required, sincetest-det-deploy-localconsumes the images generated thereTest Plan
Make sure
test-det-deploy-localsucceeds on CIChecklist
docs/release-notes/.See Release Note for details.