fix: Skip expected error from web socket #9194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9194 +/- ##
==========================================
- Coverage 44.72% 44.72% -0.01%
==========================================
Files 1266 1266
Lines 154770 154774 +4
Branches 2438 2438
==========================================
+ Hits 69225 69226 +1
- Misses 85313 85316 +3
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gt2345
changed the title
gt2345
force-pushed
the
gt/363-skip-expected-error
branch
from
f14b296
to
f82b5b7
Compare
gt2345
force-pushed
the
gt/363-skip-expected-error
branch
from
f82b5b7
to
baada59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
MD-363
Description
When the web socket connection closes from client side, server side read would receive expected error, and it can be confusing if displayed.
Test Plan
Monitor the master log, then refresh the webpage, there should not be any error regarding web socket
Checklist
docs/release-notes/.See Release Note for details.