test: use devcluster for react tests [INFENG-449] #9185
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9185 +/- ##
==========================================
- Coverage 44.75% 37.46% -7.29%
==========================================
Files 1266 597 -669
Lines 154655 92951 -61704
Branches 2438 2439 +1
==========================================
- Hits 69212 34825 -34387
+ Misses 85211 57894 -27317
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djanicekpach
force-pushed
the
djanicek/infenf-449/devcluster-react
branch
from
db05587
to
bc8c6bf
Compare
|
can we please have human-readable commit titles so one could make sense of what's happening from |
djanicekpach
changed the title
.circleci/real_config.yml
Outdated
| - run: | | ||
| apt-get update && sudo apt-get install -y ca-certificates curl make sudo python3-pip iproute2 tar | ||
| # Docker repo setup DNJ TODO - move to own step and vet all deps | ||
| sudo install -m 0755 -d /etc/apt/keyrings | ||
| sudo curl -fsSL https://download.docker.com/linux/ubuntu/gpg -o /etc/apt/keyrings/docker.asc | ||
| sudo chmod a+r /etc/apt/keyrings/docker.asc | ||
| echo \ | ||
| "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu \ | ||
| $(. /etc/os-release && echo "$VERSION_CODENAME") stable" | \ | ||
| sudo tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
| apt-get update && sudo apt-get -y install docker-ce docker-ce-cli containerd.io | ||
| sudo systemctl start docker |
There was a problem hiding this comment.
we have other jobs using devcluster on circleci, and they don't have to setup docker like this. why do we need this here?
There was a problem hiding this comment.
I suspect it was from the container_name on the postgres config. I assume that starts postgres in docker. I'm trying with that removed. Is this config documented somewhere? I looked in devcluster and didn't see anything that stuck out in the help or readme
There was a problem hiding this comment.
we have a bunch of jobs in real_config.yaml which run install-devcluster and start-devcluster. they use the same machine-image, and they don't setup docker.
e.g. here's one which runs db stage only so it'll need docker: https://github.com/determined-ai/determined/blob/main/.circleci/real_config.yml#L1905
There was a problem hiding this comment.
I remember now. In the initial iteration we used the official playwright image, but with devcluster this leads to a docker-in-docker pain-scenario. I switched to using our default vm image, using standard dependency steps, and just installing playwright after. I deleted this step entirely since it shouldn't be necessary anymore. I'll update this comment if it seems like any additional dependencies are needed.
djanicekpach
force-pushed
the
djanicek/infenf-449/devcluster-react
branch
from
92ea55f
to
aaa3123
Compare
|
OK, both test-e2e-react jobs are now passing, and I'm rebased on main with Eric's latest changes, so this should unstick the UI tests at least. I have some follow-ups to get it stable long term, but I figure it's best to get it passing for now. |
test: use devcluster for react tests INFENG-449
Ticket
infeng-449
Description
use devcluster for react tests rather than a shared backend. THis should alleviate a lot of repeatability issues at the cost of speed, but I think the trade-off has shown that it's worth it.
This overrides ENV variables setup by circle-ci. (lines 1701-1705) Once this merges, I can change the variables in circle and I'll create a -new PR to remove the override from this config. I think that lets this merge with 0 downtime. If I change the ENV vars it will have a mismatch before or after this merges briefly.
Fast-follow items that I'll work on next once tests are passing again: https://hpe-aiatscale.atlassian.net/browse/INFENG-636
Test Plan
Ran CI
Checklist
docs/release-notes/.See Release Note for details.