Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add typing annotations for zmq #9176

Merged
merged 2 commits into from
Apr 16, 2024
Merged

chore: add typing annotations for zmq #9176

merged 2 commits into from
Apr 16, 2024

Conversation

MikhailKardash
Copy link
Contributor

Ticket

None

Description

Fix linting issue with mypy. zmq.Context is generic and needs a type. Adding the default type as referenced in zmq docs

Test Plan

lint-python passes

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d1a4d47
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/661ea813b0ba920008691ce6

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.32%. Comparing base (3105407) to head (d1a4d47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9176      +/-   ##
==========================================
- Coverage   45.56%   40.32%   -5.24%     
==========================================
  Files        1188      625     -563     
  Lines      147293    94761   -52532     
  Branches     2428     2428              
==========================================
- Hits        67107    38212   -28895     
+ Misses      79963    56326   -23637     
  Partials      223      223              
Flag Coverage Δ
harness 52.15% <100.00%> (-11.87%) ⬇️
web 35.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/ipc.py 36.77% <100.00%> (-32.53%) ⬇️

... and 626 files with indirect coverage changes

@MikhailKardash MikhailKardash marked this pull request as ready for review April 16, 2024 16:40
@MikhailKardash MikhailKardash requested a review from a team as a code owner April 16, 2024 16:40
@MikhailKardash MikhailKardash merged commit e6c0c99 into main Apr 16, 2024
65 of 82 checks passed
@MikhailKardash MikhailKardash deleted the ipc_linting branch April 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants