-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Unfork Enterprise Edition (EE) and require license key for EE features #9168
Conversation
Docsite preview being generated for this PR. |
✅ Deploy Preview for determined-ui canceled.
|
Docsite preview being generated for this PR. |
1 similar comment
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9168 +/- ##
==========================================
- Coverage 45.47% 40.39% -5.08%
==========================================
Files 1197 748 -449
Lines 147637 105203 -42434
Branches 2438 2438
==========================================
- Hits 67138 42498 -24640
+ Misses 80267 62473 -17794
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Docsite preview being generated for this PR. |
1 similar comment
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Co-authored-by: Keita Nonaka <keita.nonaka@hpe.com>
Co-authored-by: Keita Nonaka <keita.nonaka@hpe.com>
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
1 similar comment
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
…eatures (#9168) Co-authored-by: Keita Nonaka <keita.nonaka@hpe.com>
Ticket
DET-10057
Description
This PR contains the squashed contents of EE, which has been secured by a license check. The PR is massive, and here are some of my comments on the contents and things to pay attention to:
Things I changed:
.circleci/real_config.yml
: lots of merging EE/OSS and creating new workflows and jobsharness/determined/deploy/local/cluster_utils.py
: modified so that enterprise edition is an option the user selects (previously, EE and OSS versions were hard coded in their respective repos)ee_migrations
folder.tools/slurmcluster.sh
has been placed indev-scripts
repo and a comment has been left in its place.webui/react
stuff - added stuff that switches brandingThings I didnt change (and some commentary):
RequireMockWorkspaceID
)tools/scripts/licenses
is all different licenses that we probably want to keepTest Plan
Make sure each of these features work: #9172, #9173, and #9086. In addition, make sure CI is running and doesn't fail on build or setup steps. Lastly, check the license gating feature to make sure it works.
Test license key: Setup devcluster so that it is running some enterprise feature, such as RBAC, SSO, or dispatcher RM. Master should panic and stop you from starting up with these features enabled. Next, use the license generation tool and follow the steps to generate your license. Run devcluster again and verify that the EE features now work.
Checklist
docs/release-notes/
.See Release Note for details.