fix: single-searcher MNIST example runs for multiple epochs #9160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this searcher is run for a single epoch it doesn't get a chance to report progress before the entire experiment is complete. This means that the progress bar in the web jumps from 0 to 100 in a step change. The step-change makes it look like something is broken. This eliminates that and demonstrates that the progress bar is working.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9160 +/- ##
==========================================
- Coverage 45.72% 39.66% -6.06%
==========================================
Files 1179 1026 -153
Lines 146795 135121 -11674
Branches 2420 2420
==========================================
- Hits 67123 53601 -13522
- Misses 79458 81306 +1848
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more. |
JComins000
pushed a commit
that referenced
this pull request
Apr 22, 2024
When this searcher is run for a single epoch it doesn't get a chance to report progress before the entire experiment is complete. This means that the progress bar in the web jumps from 0 to 100 in a step change. The step-change makes it look like something is broken. This eliminates that (by switching the searcher to step on batches) and demonstrates that the progress bar is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this searcher is run for a single epoch it doesn't get a chance to report progress before the entire experiment is complete. This means that the progress bar in the web jumps from 0 to 100 in a step change.
The step-change makes it look like something is broken. This eliminates that (by switching the searcher to step on batches) and demonstrates that the progress bar is working.
MLG-1522
Ticket
Description
Test Plan
Run a single-searcher experiment using
examples/tutorials/mnist_pytorch/const.yamlas config. Watch that the progress bar in the web UI goes through intermediate steps as the experiment runs (that it doesn't jump directly from 0% complete to 100%).Checklist
docs/release-notes/.See Release Note for details.