Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: style fix for helm initialUserPassword #9158

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Apr 12, 2024

Ticket

No ticket for this.

Description

The tiniest nit.

Test Plan

Tested locally, needs no testing.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 9668db0
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/661dcf82e022780008747dd8

@stoksc stoksc added to-cherry-pick Pull requests that need to be cherry-picked into the current release and removed to-cherry-pick Pull requests that need to be cherry-picked into the current release labels Apr 12, 2024
Copy link
Contributor

@tayritenour tayritenour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoksc stoksc force-pushed the fix-initial-user-password-helm branch from f0dcce5 to 9668db0 Compare April 16, 2024 01:08
@stoksc stoksc enabled auto-merge (squash) April 16, 2024 01:08
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.84%. Comparing base (35d249f) to head (9668db0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9158      +/-   ##
==========================================
- Coverage   46.03%   40.84%   -5.19%     
==========================================
  Files         768      631     -137     
  Lines      106729    95720   -11009     
  Branches     2428     2429       +1     
==========================================
- Hits        49131    39097   -10034     
+ Misses      57375    56400     -975     
  Partials      223      223              
Flag Coverage Δ
harness 53.50% <ø> (-10.52%) ⬇️
web 35.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 200 files with indirect coverage changes

@stoksc stoksc merged commit b194686 into main Apr 17, 2024
64 of 82 checks passed
@stoksc stoksc deleted the fix-initial-user-password-helm branch April 17, 2024 22:33
@stoksc
Copy link
Contributor Author

stoksc commented Apr 17, 2024

weird, it says i merged this but i definitely didn't. i wonder if automerge bugged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants