Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make the data_dir consistent to other advertised devc configs #9157

Merged
merged 1 commit into from
Apr 16, 2024
Merged

chore: make the data_dir consistent to other advertised devc configs #9157

merged 1 commit into from
Apr 16, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Apr 12, 2024 •
edited by jira bot
Loading

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 12, 2024
@hamidzr hamidzr requested a review from stoksc April 12, 2024 16:34
@hamidzr hamidzr marked this pull request as ready for review April 12, 2024 16:34
@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ec43ff3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6619629dca6813000859afea

stoksc
stoksc approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine with me. it never affects me but i could see it tripping others up.

@hamidzr hamidzr merged commit 3105407 into main Apr 16, 2024
71 of 86 checks passed
@hamidzr hamidzr deleted the hz-multirm-config branch April 16, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoksc stoksc stoksc approved these changes

Assignees

@stoksc stoksc

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamidzr @stoksc