Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TensorBoard visualization from batch actions. #9156

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Apr 12, 2024

Ticket: ET-167

Description

The TensorBoard was showing wrong data when being fired from the batch actions button.

After some investigation, I've noticed that if fired from the context menu on an individual experiment it works just as expected.

The only difference in the API call was the filters, which we grab from the excludedExperimentIds

Payload:

Screenshot 2024-04-12 at 12 45 55

Screenshot 2024-04-12 at 12 45 49

Response:

Screenshot 2024-04-12 at 12 37 23

Screenshot 2024-04-12 at 12 36 29

So, after removing it, it works just fine:

Screenshot 2024-04-12 at 12 46 19

Before:

From batch actions:

Screenshot 2024-04-12 at 12 35 51

From the context menu:

Screenshot 2024-04-12 at 12 37 12

Now:

From batch actions:

Screenshot 2024-04-12 at 12 46 58

Screenshot 2024-04-12 at 12 35 44

Test Plan

  • go to the experiment list
  • select a couple of experiments
  • open TensorBoard
  • the experiment list should match the previous selection

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 156dcfa
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66195ae48349b2000733c923
😎 Deploy Preview https://deploy-preview-9156--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 39.73%. Comparing base (5854b8b) to head (156dcfa).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9156      +/-   ##
==========================================
- Coverage   45.55%   39.73%   -5.83%     
==========================================
  Files        1133      825     -308     
  Lines      142104   103512   -38592     
  Branches     2414     2414              
==========================================
- Hits        64738    41130   -23608     
+ Misses      77157    62173   -14984     
  Partials      209      209              
Flag Coverage Δ
harness ?
web 36.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/TableActionBar.tsx 0.00% <0.00%> (ø)

... and 308 files with indirect coverage changes

@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 12, 2024
@thiagodallacqua-hpe thiagodallacqua-hpe merged commit 8b83122 into main Apr 12, 2024
81 of 93 checks passed
@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/ET-167 branch April 12, 2024 16:50
dai-release bot pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants