-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: user tests [INFENG-455] #9152
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f49774a
to
c89a2fc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9152 +/- ##
==========================================
- Coverage 44.72% 44.22% -0.51%
==========================================
Files 1266 1270 +4
Lines 154770 155041 +271
Branches 2438 2443 +5
==========================================
- Hits 69225 68569 -656
- Misses 85313 86236 +923
- Partials 232 236 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, a couple of nice-to-have comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but otherwise looks good
23fa140
to
c5aab5b
Compare
38b91d7
to
5d81a91
Compare
7de8e47
to
cc39a55
Compare
bcf0f37
to
680a25c
Compare
Co-authored-by: Keita Nonaka <keita.nonaka@hpe.com>
33c27ad
to
d9b15e4
Compare
@@ -19,48 +20,117 @@ test.describe('User Management', () => { | |||
await expect(page).toHaveURL(userManagementPage.url); | |||
}); | |||
|
|||
test.skip('Users table count matches admin page users tab', async ({ page }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip until this PR
https://github.com/determined-ai/determined/pull/9214/commits
Ticket
INFENG-455
INFENG-556
Description
user management page tests. this one is for U in CRUD.
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.