Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: user tests [INFENG-455] #9152

Merged
merged 25 commits into from
Apr 22, 2024
Merged

test: user tests [INFENG-455] #9152

merged 25 commits into from
Apr 22, 2024

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented Apr 11, 2024

Ticket

INFENG-455

INFENG-556

Description

user management page tests. this one is for U in CRUD.

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@JComins000 JComins000 requested a review from a team as a code owner April 11, 2024 20:14
@cla-bot cla-bot bot added the cla-signed label Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 7bb55bc
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66269800da52260008e486ec
😎 Deploy Preview https://deploy-preview-9152--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 275 lines in your changes are missing coverage. Please review.

Project coverage is 44.22%. Comparing base (1b212ae) to head (7bb55bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9152      +/-   ##
==========================================
- Coverage   44.72%   44.22%   -0.51%     
==========================================
  Files        1266     1270       +4     
  Lines      154770   155041     +271     
  Branches     2438     2443       +5     
==========================================
- Hits        69225    68569     -656     
- Misses      85313    86236     +923     
- Partials      232      236       +4     
Flag Coverage Δ
backend 41.57% <ø> (+<0.01%) ⬆️
harness 62.47% <ø> (-1.67%) ⬇️
web 35.23% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...react/src/e2e/models/components/CreateUserModal.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/models/hew/Toast.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/fixtures/global-fixtures.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/models/hew/Modal.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/utils/naming.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/utils/polling.ts 0.00% <0.00%> (ø)
...react/src/e2e/models/pages/Admin/UserManagement.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/models/hew/Pagination.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/models/hew/Select.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/fixtures/user.fixture.ts 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

Copy link
Contributor

@djanicekpach djanicekpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a couple of nice-to-have comments.

webui/react/src/e2e/tests/userManagement.spec.ts Outdated Show resolved Hide resolved
webui/react/src/e2e/tests/userManagement.spec.ts Outdated Show resolved Hide resolved
@JComins000 JComins000 requested a review from a team as a code owner April 15, 2024 18:16
Copy link
Contributor

@djanicekpach djanicekpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but otherwise looks good

webui/react/src/e2e/tests/userManagement.spec.ts Outdated Show resolved Hide resolved
@JComins000 JComins000 requested a review from a team as a code owner April 15, 2024 20:23
@loksonarius loksonarius removed their request for review April 16, 2024 14:56
@JComins000 JComins000 force-pushed the jcom/INFENG-455/user-tests branch 10 times, most recently from bcf0f37 to 680a25c Compare April 17, 2024 22:02
@cla-bot cla-bot bot added the cla-signed label Apr 22, 2024
@determined-ci determined-ci removed the documentation Improvements or additions to documentation label Apr 22, 2024
@@ -19,48 +20,117 @@ test.describe('User Management', () => {
await expect(page).toHaveURL(userManagementPage.url);
});

test.skip('Users table count matches admin page users tab', async ({ page }) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JComins000 JComins000 merged commit 8caf3cb into main Apr 22, 2024
84 of 96 checks passed
@JComins000 JComins000 deleted the jcom/INFENG-455/user-tests branch April 22, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants