fix: count determined-system pods as det pods [RM-148] #9148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9148 +/- ##
==========================================
+ Coverage 45.46% 45.48% +0.02%
==========================================
Files 1197 1197
Lines 147556 147558 +2
Branches 2438 2437 -1
==========================================
+ Hits 67092 67123 +31
+ Misses 80232 80203 -29
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kkunapuli
reviewed
Apr 15, 2024
kkunapuli
approved these changes
Apr 15, 2024
stoksc
approved these changes
Apr 16, 2024
|
can we add a test for this? |
carolinaecalderon
force-pushed
the
carolinac/rm-148
branch
from
aa77cbe
to
0b027c1
Compare
JComins000
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
RM-148
Description
If a pod has a "determined system", "determined preemption" OR "determined" label, don't count it as a "nonDet" pod. This fixes a bug where the db/master pods were counted twice as det pods & nonDet pods, and the master logs gave a
too many pods mapping to nodewarning.Test Plan
Spin up your own small CPU cluster (or use mine -- slack me for the IP), and check that there are
# of slots - 2slots left in the "default RM". This means that the db & master pod are being counted just once (correct). If there are fewer slots available than expected, or no slots free, this means the pods are being double counted.Additionally, try spinning up your own experiment and make sure you don't get the "too many pods" warning in your master logs.
Checklist
docs/release-notes/.See Release Note for details.