feat: add helm master level config template for tcd startup hooks #9135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidzr
changed the title
hamidzr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9135 +/- ##
==========================================
- Coverage 46.54% 41.36% -5.18%
==========================================
Files 755 727 -28
Lines 104838 103063 -1775
Branches 2413 2414 +1
==========================================
- Hits 48795 42633 -6162
- Misses 55834 60221 +4387
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
hamidzr
force-pushed
the
hz-startup-hook-helm
branch
from
08fe023
to
00b1f8c
Compare
✅ Deploy Preview for determined-ui canceled.
|
hamidzr
changed the title
hamidzr
requested review from
a team and
carolinaecalderon
and removed request for
a team
NicholasBlaskey
approved these changes
Apr 10, 2024
stoksc
reviewed
Apr 10, 2024
hamidzr
added
the
to-cherry-pick
stoksc
approved these changes
Apr 10, 2024
BOsterbuhr
approved these changes
Apr 10, 2024
hamidzr
force-pushed
the
hz-startup-hook-helm
branch
from
aeb41d5
to
5a0c312
Compare
did I? 🤷🏼 (feel free to ignore it) |
|
having problems with merging my prs due to github outage |
hamidzr
force-pushed
the
hz-startup-hook-helm
branch
from
3fb1450
to
44d1d95
Compare
|
@determined-ai/backend @determined-ai/infrastructure can I get stampes to make github happy? |
hamidzr
changed the title
loksonarius
approved these changes
Apr 10, 2024
dannysauer
approved these changes
Apr 10, 2024
(cherry picked from commit 6bababd)
we have so many different ways of configuring clusters we run in the ci this should work the same way on all of them
hamidzr
force-pushed
the
hz-startup-hook-helm
branch
from
3ab70fd
to
8544410
Compare
hamidzr
commented
Apr 11, 2024
| return True | ||
| pools = mc.get("resource_pools", []) | ||
| for p in pools: | ||
| print(p) |
There was a problem hiding this comment.
shoot I forgot to take this out but not gonna rerun ci at this point since we're waiting to cherry-pick it
dai-release bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
(cherry picked from commit b109108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://hpe-aiatscale.atlassian.net/browse/RM-105
Description
adds an option for setting master level startup hook to TCD to our helm chart
I'll rebase after the target branch is merged into main
nice
Test Plan
deploy locally to
kindand run a command with master tcd startup setChecklist
docs/release-notes/.See Release Note for details.