Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumpenv update NGC base images version to 24.03 #9132

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Apr 9, 2024

Ticket

Description

Update the base image of pytorch-ngc, pytorch-ngc-hpc, tensorflow-ngc, and tensorflow-ngc-hpc to 24.03 to address critical vulnerabilities.

Environments repo PR: https://github.com/determined-ai/environments/pull/253/files

Test Plan

CI tests.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@jgongd jgongd requested review from a team as code owners April 9, 2024 14:21
@cla-bot cla-bot bot added the cla-signed label Apr 9, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 9, 2024
@determined-ci determined-ci requested a review from a team April 9, 2024 14:21
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 5571364
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6618638268925c0008427480
😎 Deploy Preview https://deploy-preview-9132--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgongd jgongd force-pushed the jgong/feat/update-ngc-version branch 3 times, most recently from 57b0489 to 4d97dd0 Compare April 9, 2024 16:44
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgongd jgongd requested review from MikhailKardash and removed request for wes-turner April 9, 2024 18:12
@jgongd jgongd force-pushed the jgong/feat/update-ngc-version branch from 4d97dd0 to 5571364 Compare April 11, 2024 22:26
@determined-ci determined-ci requested a review from a team April 11, 2024 22:26
@jgongd jgongd changed the title feat: Update NGC version to 24.03 chore: bumpenv update NGC version to 24.03 Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.20%. Comparing base (d0497da) to head (5571364).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9132      +/-   ##
==========================================
- Coverage   46.54%   46.20%   -0.34%     
==========================================
  Files         755     1175     +420     
  Lines      104838   145372   +40534     
  Branches     2413     2414       +1     
==========================================
+ Hits        48795    67169   +18374     
- Misses      55834    77994   +22160     
  Partials      209      209              
Flag Coverage Δ
backend 43.69% <100.00%> (+9.44%) ⬆️
harness 64.03% <100.00%> (+1.08%) ⬆️
web 36.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/gcp/constants.py 100.00% <100.00%> (ø)
master/internal/config/provconfig/aws_config.go 11.20% <ø> (ø)
master/internal/config/provconfig/gcp_config.go 26.76% <100.00%> (ø)

... and 438 files with indirect coverage changes

@jgongd jgongd changed the title chore: bumpenv update NGC version to 24.03 chore: bumpenv update NGC base images version to 24.03 Apr 11, 2024
@jgongd jgongd merged commit 1037d83 into main Apr 17, 2024
77 of 89 checks passed
@jgongd jgongd deleted the jgong/feat/update-ngc-version branch April 17, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants