Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set the default data vol to be a docker volume instead of a mount #9127

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Apr 8, 2024

Ticket

Description

docker volumes are more resilient to user system configuration. users should be less likely to run into os level issues with this approach

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 8, 2024
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 380ca39
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6614689085a4c00008b06a9c

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (d5f807d) to head (380ca39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9127   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files        1174     1174           
  Lines      145186   145186           
  Branches     2412     2413    +1     
=======================================
+ Hits        67025    67031    +6     
+ Misses      77953    77947    -6     
  Partials      208      208           
Flag Coverage Δ
backend 43.50% <ø> (+0.02%) ⬆️
harness 63.99% <ø> (-0.01%) ⬇️
web 36.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@hamidzr hamidzr requested review from a team and NicholasBlaskey and removed request for a team April 9, 2024 05:09
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this was causing issues but looks reasonable to me

@hamidzr
Copy link
Contributor Author

hamidzr commented Apr 9, 2024

I don't understand how this was causing issues but looks reasonable to me

My understanding: Depending on how you have docker installed, when given a random directory it's at the mercy of the filesystem and OS's access control. I've run into these myself once I switched to Rancher and now have multiple docker contexts. I haven't been able to pinpoint why but the nice thing here is we can just have docker handle it

@hamidzr hamidzr merged commit 2c3ce29 into main Apr 9, 2024
78 of 90 checks passed
@hamidzr hamidzr deleted the hz-docker-vol-devcluster branch April 9, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants