Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: det deploy aws adds tags to dynamic agents [RM-140] #9106

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

Description

det deploy aws will apply the add_tags to dynamic agents.

Test Plan

Launch a cluster

det deploy aws up --cluster-id clusteridtest --keypair testkeypair \
    --deployment-type simple \
        --det-version f78b9aa68e3428a75be043de16e75dc863bc0229 \
    --add-tag owner=nickblaskey \
    --add-tag gh_team=rm_team

run an job so a dynamic agent is launched, then check that it is filled in

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner April 4, 2024 13:45
@cla-bot cla-bot bot added the cla-signed label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 47.09%. Comparing base (d4eed0e) to head (6c14406).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9106      +/-   ##
==========================================
- Coverage   48.48%   47.09%   -1.39%     
==========================================
  Files         738     1156     +418     
  Lines      102297   142589   +40292     
  Branches     2423     2421       -2     
==========================================
+ Hits        49595    67155   +17560     
- Misses      52512    75244   +22732     
  Partials      190      190              
Flag Coverage Δ
backend 43.04% <ø> (+8.83%) ⬆️
harness 64.06% <10.00%> (-0.02%) ⬇️
web 38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ess/determined/deploy/aws/deployment_types/base.py 39.74% <10.00%> (-3.74%) ⬇️

... and 419 files with indirect coverage changes

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6c14406
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660f0259aba63f00084928ae

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 4, 2024
@determined-ci determined-ci requested a review from a team April 4, 2024 13:48
Copy link
Contributor

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

docs/setup-cluster/aws/install-on-aws.rst Outdated Show resolved Hide resolved
@NicholasBlaskey NicholasBlaskey merged commit 75b1ff4 into main Apr 4, 2024
69 of 82 checks passed
@NicholasBlaskey NicholasBlaskey deleted the det_deploy_dynamic_propgate branch April 4, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants