Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent checkpoint modals from closing on their own [ET-116] [ET-120] #9094

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

EmilyBonar
Copy link
Contributor

Description

Addresses the bugs from release part here https://github.com/determined-ai/release-party-issues/issues/1594

Test Plan

  • Go to the checkpoints table of a single trial experiment
  • Click on the flag in the Checkpoint column to open the checkpoint modal
  • Switch between browser tabs and confirm that the modal doesn't close
  • Test registering checkpoint
  • Repeat all tests on the Workloads table on the Overview tab of the same experiment (below metrics graph)
  • Repeat all tests by clicking the "Best Checkpoint" card on the Overview tab
  • Repeat all tests on the Trials table of a multi trial experiment

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@EmilyBonar EmilyBonar added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 3, 2024
@EmilyBonar EmilyBonar requested a review from a team as a code owner April 3, 2024 17:27
@cla-bot cla-bot bot added the cla-signed label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 0e73d40
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660db3486338f4000818ca6e
😎 Deploy Preview https://deploy-preview-9094--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 180 lines in your changes are missing coverage. Please review.

Project coverage is 40.12%. Comparing base (3f2d6ab) to head (0e73d40).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9094      +/-   ##
==========================================
- Coverage   47.06%   40.12%   -6.95%     
==========================================
  Files        1154      831     -323     
  Lines      142378   102998   -39380     
  Branches     2423     2387      -36     
==========================================
- Hits        67006    41324   -25682     
+ Misses      75182    61484   -13698     
  Partials      190      190              
Flag Coverage Δ
harness ?
web 38.16% <11.76%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...act/src/pages/TrialDetails/TrialDetailsMetrics.tsx 21.85% <0.00%> (+0.80%) ⬆️
...ebui/react/src/pages/TrialDetails/TrialInfoBox.tsx 45.16% <27.27%> (+13.48%) ⬆️
...i/react/src/components/RegisterCheckpointModal.tsx 20.24% <21.05%> (-53.73%) ⬇️
webui/react/src/hooks/useCheckpointFlow.tsx 28.57% <21.42%> (+2.85%) ⬆️
.../pages/ExperimentDetails/ExperimentCheckpoints.tsx 14.04% <11.53%> (-0.14%) ⬇️
webui/react/src/hooks/useFetchModels.tsx 28.20% <3.57%> (-3.23%) ⬇️
...t/src/pages/TrialDetails/TrialDetailsWorkloads.tsx 18.66% <10.25%> (-0.72%) ⬇️
...t/src/pages/ExperimentDetails/ExperimentTrials.tsx 12.52% <5.88%> (-0.23%) ⬇️

... and 325 files with indirect coverage changes

Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmilyBonar EmilyBonar requested a review from ashtonG April 3, 2024 19:52
@EmilyBonar EmilyBonar merged commit 943b2cb into main Apr 3, 2024
69 of 81 checks passed
@EmilyBonar EmilyBonar deleted the emilybonar/fix-checkpoint-modals branch April 3, 2024 20:09
dai-release bot pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants