Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unshadow more builtins #9092

Merged
merged 1 commit into from
Apr 3, 2024
Merged

chore: unshadow more builtins #9092

merged 1 commit into from
Apr 3, 2024

Conversation

wes-turner
Copy link
Contributor

  1. A couple missed instances of license were missed. Now they're lic.
  2. type was used. Didn't want to change the interface, so this just got a noqa.

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

1. A couple missed instances of `license` were missed. Now they're
   `lic`.
2. `type` was used. Didn't want to change the interface, so this just
   got a `noqa`.
@cla-bot cla-bot bot added the cla-signed label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a2b0050
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660d8b93cfb41e000821b3c0

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.95%. Comparing base (3688c3f) to head (a2b0050).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9092      +/-   ##
==========================================
- Coverage   48.48%   46.95%   -1.53%     
==========================================
  Files         738     1141     +403     
  Lines      102297   141760   +39463     
  Branches     2423     2423              
==========================================
+ Hits        49598    66570   +16972     
- Misses      52509    75000   +22491     
  Partials      190      190              
Flag Coverage Δ
backend 43.05% <ø> (+8.84%) ⬆️
harness 63.90% <ø> (-0.18%) ⬇️
web 38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 442 files with indirect coverage changes

@wes-turner wes-turner merged commit 2af21ee into main Apr 3, 2024
72 of 85 checks passed
@wes-turner wes-turner deleted the wes/shadowed-builtins branch April 3, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants