fix: no more shadowing "license"

[wes-turner]

license is a builtin constant (added by the site module). Let's not shadow it.

Description

Test Plan

No change in anything user-facing. No release testing necessary.

Commentary (optional)

Checklist

• Changes have been manually QA'd
• User-facing API changes need the "User-facing API Change" label.
• Release notes should be added as a separate file under docs/release-notes/.
  See Release Note for details.
• Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

[netlify]

✅ Deploy Preview for determined-ui canceled.

Name	Link
🔨 Latest commit	562f6e5
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/660b658947254d00099c2a9a

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.06%. Comparing base (3f2d6ab) to head (562f6e5).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9085      +/-   ##
==========================================
+ Coverage   47.00%   47.06%   +0.05%     
==========================================
  Files        1154     1154              
  Lines      142378   142378              
  Branches     2423     2423              
==========================================
+ Hits        66927    67004      +77     
+ Misses      75261    75184      -77     
  Partials      190      190              

Flag	Coverage Δ
backend	42.89% <ø> (-0.01%)	⬇️
harness	64.07% <ø> (+0.20%)	⬆️
web	38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

[hamidzr]

lgtm assuming no other lic vars exist in the same scope. thanks!

[hamidzr]

lgtm assuming no other lic vars exist in the same scope. thanks!

If this can be caught by CI how did it not fail the original pr?

[wes-turner]

lgtm assuming no other lic vars exist in the same scope. thanks!

If this can be caught by CI how did it not fail the original pr?

It's new functionality in flake8-builtins.