Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix master config and experiment config for log retention #9075

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Mar 29, 2024

Description

Fixing the experiment and master config to make it consistent and adding a wrapper layer.

Test Plan

Make sure all tests pass.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 29, 2024
Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c9585b4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660c28fcf54efc0008a9eec9
😎 Deploy Preview https://deploy-preview-9075--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@determined-ci determined-ci requested a review from a team April 1, 2024 17:37
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 1, 2024
@salonig23 salonig23 marked this pull request as ready for review April 1, 2024 17:38
@salonig23 salonig23 requested review from a team as code owners April 1, 2024 17:38
@salonig23 salonig23 requested a review from jgongd April 1, 2024 17:38
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.80%. Comparing base (3f2d6ab) to head (c9585b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9075      +/-   ##
==========================================
- Coverage   47.06%   42.80%   -4.27%     
==========================================
  Files        1154      710     -444     
  Lines      142378   100529   -41849     
  Branches     2423     2423              
==========================================
- Hits        67006    43027   -23979     
+ Misses      75182    57312   -17870     
  Partials      190      190              
Flag Coverage Δ
backend 34.20% <ø> (-8.70%) ⬇️
harness 49.58% <ø> (-14.50%) ⬇️
web 38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 578 files with indirect coverage changes

@salonig23 salonig23 force-pushed the fix-config-log-retention branch 2 times, most recently from f21075e to 73904e6 Compare April 1, 2024 18:37
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edits

@determined-ci determined-ci requested a review from a team April 1, 2024 20:14
Copy link
Contributor

@jgongd jgongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model dev stamp

@salonig23 salonig23 merged commit 8f02a7f into main Apr 2, 2024
97 of 100 checks passed
@salonig23 salonig23 deleted the fix-config-log-retention branch April 2, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants