feat: add kill run endpoint #9061
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9061 +/- ##
==========================================
- Coverage 44.75% 44.72% -0.03%
==========================================
Files 1266 1266
Lines 154656 154770 +114
Branches 2439 2439
==========================================
+ Hits 69213 69225 +12
- Misses 85211 85313 +102
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e2e_tests/tests/run/test_api.py
Outdated
| resp = bindings.get_SearchRuns( | ||
| test_session, | ||
| limit=1, | ||
| filter="""{"filterGroup":{"children":[{"columnName":"id","kind":"field", | ||
| "location":"LOCATION_TYPE_RUN","operator":"=","type":"COLUMN_TYPE_NUMBER","value":""" | ||
| + str(run_id) | ||
| + """}],"conjunction":"and","kind":"group"},"showArchived":false}""", | ||
| ) |
There was a problem hiding this comment.
we really need a simple "GET /runs/:id". can you at least make a ticket for it, if it doesn't exist?
| Id: runID, | ||
| }) | ||
| if err != nil { | ||
| results = append(results, &apiv1.RunActionResult{ |
There was a problem hiding this comment.
i guess after really sinking into this PR, i've realized this "wanting a result back for everything" really complicates it. how do we plan to use this result? how necessary is it?
because I was thinking, why are we not just doing base select with runs, filtering for killable runs by adding a WHERE state in (...terminal states) and request_id IS NOT NULL, then passing those all to kill trial. at that point, if there are any errors we can pass them back to the user? that seems sufficient and twice as simple?
There was a problem hiding this comment.
This is how the responses were structured in the Experiment equivalent functions (PauseExperiments, DeleteExperiments, etc...) I believe as well that Frontend expects this behaviour.
Co-authored-by: Bradley Laney <bradley.laney@hpe.com>
Co-authored-by: Bradley Laney <bradley.laney@hpe.com>
Description
Adding KillRuns endpoint to Run API for FlatRuns table
Test Plan
e2e tests should pass
Checklist
docs/release-notes/.See Release Note for details.
Ticket
ET-92