feat: add slot stats to /agents endpoints #9048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
scale up the output
turn off topology rendering
intro slot stats
slot stats
fill in summary
make copies
add a flag to exclude slots
comment cleanup
set excludeSlots flag when calling getAgents in webui
cleanup
inform about exact disabled slots
implement it
index via enum names instead of int values
sample out
```
"slotStats": {
"deviceTypeCounts": {
"TYPE_CPU": 4
},
"disabledSlots": {},
"drainingCount": 0,
"slotStates": {
"0": "STATE_PULLING"
},
"stateCounts": {
"STATE_PULLING": 1
}
},
```
switch to list of strings
new stats
take out old schema?
simplify initializing the stats
also add option to exclude containers?
impelement and use exclude_containers
disable topology view for > MAX_USABLE_NODES
note for topology
reenable pagination
expose a way to togggle requesting slots
no summary flag
hamidzr
commented
Mar 26, 2024
Comment on lines
48
to
51
| // Map of device type to device stats. | ||
| map<string, DeviceStats> type_stats = 6; | ||
| // Map of device brands to device stats. | ||
| map<string, DeviceStats> brand_stats = 7; |
There was a problem hiding this comment.
just keep these two
There was a problem hiding this comment.
reminder for myself. my plan is to just these keep these two new structs and we shouldn't need the rest.
hamidzr
requested review from
kkunapuli,
julian-determined-ai and
keita-determined
and removed request for
julian-determined-ai
4 tasks
kkunapuli
reviewed
Mar 26, 2024
kkunapuli
approved these changes
Mar 26, 2024
keita-determined
changed the title
|
changed title with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9048 +/- ##
=======================================
Coverage 47.80% 47.81%
=======================================
Files 1161 1161
Lines 143646 143713 +67
Branches 2373 2371 -2
=======================================
+ Hits 68676 68714 +38
- Misses 74817 74846 +29
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I'd change it to feat: that'd also be tested. I think that'd be more accurate. |
hamidzr
changed the title
hamidzr
added
the
to-cherry-pick
dai-release bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
(cherry picked from commit e8dba6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
waiting on web to confirm the schema is sufficient
Test Plan
look at the added stats in the API to see the values are as expected by brand and dev type
Commentary (optional)
putting this up to get early feedback on the schema changes
not going to land any of the web changes via this pr
Checklist
docs/release-notes/.See Release Note for details.
Ticket
related to https://hpe-aiatscale.atlassian.net/browse/RM-108