-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove agentID type from agentrm #9040
refactor: remove agentID type from agentrm #9040
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9040 +/- ##
==========================================
- Coverage 47.80% 47.80% -0.01%
==========================================
Files 1161 1161
Lines 143646 143646
Branches 2373 2373
==========================================
- Hits 68673 68672 -1
- Misses 74820 74821 +1
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a resource management ticket but was a pretty straight-forward refactor, so I reviewed it...LGTM!
Thanks for helping get rid of some unnecessary back-and-forth casting, and for removing the duplicate type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (didn't review a ton, if the compiler is happy i assume this is fine)
Description
DET-9976
Removes the
agentID
type in favor of usingaproto.ID
throughout package agentrm.Test Plan
N/A
Commentary (optional)
A little surprising that there's a net gain of SLOC, but it's because of all the new
import...aproto
lines.Also, this refactor touches a ton of untested code, but I promise it's purely a static change >.<
Checklist
docs/release-notes/
.See Release Note for details.