-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add command det model delete #9039
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9039 +/- ##
=======================================
Coverage 47.80% 47.80%
=======================================
Files 1161 1161
Lines 143646 143650 +4
Branches 2373 2371 -2
=======================================
+ Hits 68673 68679 +6
+ Misses 74820 74818 -2
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome work! I'd just rerun the react unit test to double-check that things are all good!
Description
DET-9632
Essentially identical to a convenience CLI command that was part of a PR #7175 last year as it was useful for testing at the time. It spun off into a separate ticket due to being out of scope, but it's probably still convenient to (re)include.
8b0ec75#diff-27dd013a7937c3e0392be1d4090837fec1f0fb87ef0037cac6516e447360ee40R138
Test Plan
modified e2e test which exercises the new command should pass
Checklist
docs/release-notes/
.See Release Note for details.