Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command det model delete #9039

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented Mar 22, 2024

Description

DET-9632

Essentially identical to a convenience CLI command that was part of a PR #7175 last year as it was useful for testing at the time. It spun off into a separate ticket due to being out of scope, but it's probably still convenient to (re)include.

8b0ec75#diff-27dd013a7937c3e0392be1d4090837fec1f0fb87ef0037cac6516e447360ee40R138

Test Plan

modified e2e test which exercises the new command should pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Mar 22, 2024
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit e6f775b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66019d4c836dc8000858b03d

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 47.80%. Comparing base (e4bc377) to head (e6f775b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9039   +/-   ##
=======================================
  Coverage   47.80%   47.80%           
=======================================
  Files        1161     1161           
  Lines      143646   143650    +4     
  Branches     2373     2371    -2     
=======================================
+ Hits        68673    68679    +6     
+ Misses      74820    74818    -2     
  Partials      153      153           
Flag Coverage Δ
backend 42.95% <ø> (+0.01%) ⬆️
harness 63.84% <25.00%> (-0.01%) ⬇️
web 40.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/cli/model.py 24.39% <25.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@jesse-amano-hpe jesse-amano-hpe changed the title cli: add command det model delete feat: add command det model delete Mar 22, 2024
@jesse-amano-hpe jesse-amano-hpe marked this pull request as ready for review March 22, 2024 14:24
@jesse-amano-hpe jesse-amano-hpe requested review from a team as code owners March 22, 2024 14:24
Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome work! I'd just rerun the react unit test to double-check that things are all good!

@jesse-amano-hpe jesse-amano-hpe merged commit 848b216 into main Mar 26, 2024
69 of 81 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/DET-9632/cli-delete-model branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants