-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add model version streaming #9029
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9029 +/- ##
==========================================
+ Coverage 46.16% 53.23% +7.06%
==========================================
Files 1171 770 -401
Lines 143382 82363 -61019
Branches 2410 0 -2410
==========================================
- Hits 66196 43843 -22353
+ Misses 76981 38520 -38461
+ Partials 205 0 -205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b7b5c63
to
999465d
Compare
master/static/migrations/20240328144809_add-model-versions-trigger.tx.up.sql
Outdated
Show resolved
Hide resolved
master/static/migrations/20240328144809_add-model-versions-trigger.tx.up.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frontend code ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
0d19791
to
ceab565
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Add model version streaming, this is not yet exposed to the WebUI.
There will be a separate PR for EE to handle rbac.
Test Plan
Creating/editing/deleting model and model version work as expected.
Connect to
ws://localhost:8080/stream
, should be able to subscribe and unsubscribe formodelversions
.Sample message:
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
MD-262