perf: improved textcell performance for novels #8986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the glide table performance would chug when given a text cell with lots of text to truncate. while `measureText` is more performant than getBoundingClientRectangle, it can still be problematic to call excessively. To remedy, we implement a binary search for the longest string that's still below max width, reducing the number of times we need to measure the text for longer texts at the cost of calling it a few more times for shorter texts.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8986 +/- ##
==========================================
- Coverage 47.49% 42.75% -4.74%
==========================================
Files 1168 848 -320
Lines 176296 137036 -39260
Branches 2352 2352
==========================================
- Hits 83733 58592 -25141
+ Misses 92405 78286 -14119
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilyBonar
approved these changes
Mar 13, 2024
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
This fixes an issue where the glide table performance would chug when given a text cell with lots of text to truncate. while `measureText` is more performant than getBoundingClientRectangle, it can still be problematic to call excessively. To remedy, we implement a binary search for the longest string that's still below max width, reducing the number of times we need to measure the text for longer texts at the cost of calling it a few more times for shorter texts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where the glide table performance would chug when given a text cell with lots of text to truncate. while
measureTextis more performant than getBoundingClientRectangle, it can still be problematic to call excessively. To remedy, we implement a binary search for the longest string that's still below max width, reducing the number of times we need to measure the text for longer texts at the cost of calling it a few more times for shorter texts.ET-71
Test Plan
Checklist
docs/release-notes/.See Release Note for details.
Ticket
ET-71