ci: Djanicek/infraeng 487/circle test runner #8977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8977 +/- ##
=======================================
Coverage 47.49% 47.49%
=======================================
Files 1168 1168
Lines 176315 176315
Branches 2353 2350 -3
=======================================
Hits 83732 83732
Misses 92425 92425
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
djanicekpach
force-pushed
the
djanicek/infraeng-487/circle-test-runner
branch
from
99b37b7
to
053390a
Compare
JComins000
approved these changes
Mar 12, 2024
djanicekpach
force-pushed
the
djanicek/infraeng-487/circle-test-runner
branch
from
053390a
to
28cd47e
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
* use circle test runner instead of splitter * fix xargs syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
INFRAENG-487
Circle-ci lets us re-run failed tests individually if we use the circle ci runner instead of splitting and running separately.
https://circleci.com/docs/rerun-failed-tests/
This makes it faster and cheaper to re-run failures on circle-ci since individual tests can be re-run instead of whole jobs.
Test Plan
pipeline passed and all the E2E tests took the same amount of time. Spot checking most of them, they all ran the same number of tests as main.
https://app.circleci.com/pipelines/github/determined-ai/determined/52143/workflows/311b97d9-4e74-4c18-90c2-f03abd7f3cf6/jobs/2331410
We'll have to be careful of long-running nightly e2e. I'm running a sample to insure they work. https://app.circleci.com/pipelines/github/determined-ai/determined/52143/workflows/2e6ceb8a-4d72-4ae3-9f3c-73e85358f7ee
Checklist
docs/release-notes/.See Release Note for details.