chore: Bumpenvs for NGC+ images #8975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8975 +/- ##
=======================================
Coverage 47.55% 47.55%
=======================================
Files 1168 1168
Lines 176706 176706
Branches 2356 2354 -2
=======================================
Hits 84026 84026
Misses 92522 92522
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MikhailKardash
requested review from
hkang1,
mpkouznetsov,
dzhu and
carolinaecalderon
ioga
approved these changes
Mar 8, 2024
keita-determined
approved these changes
Mar 8, 2024
tara-det-ai
reviewed
Mar 11, 2024
| Users can build their own images from a given NGC container version by using the | ||
| `build-pytorch-ngc` or `build-tensorflow-ngc` workflows found in our environments `MakeFile`. Our | ||
| environments repo is located at `https://github.com/determined-ai/environments`. | ||
|
|
There was a problem hiding this comment.
attempted to apply the following edits (hard to show restructured text formatting in a markdown comment)
:orphan:
New Features
- Include early-access NVIDIA NGC-based images in our environment offerings. These images are
accessible frompytorch-ngc <https://hub.docker.com/r/determinedai/pytorch-ngc>_ or
tensorflow-ngc <https://hub.docker.com/r/determinedai/tensorflow-ngc>. By downloading and
using these images, users acknowledge and agree to the terms and conditions of all third-party
software licenses contained within, including theNVIDIA Deep Learning Container License <https://developer.download.nvidia.com/licenses/NVIDIA_Deep_Learning_Container_License.pdf>__.
Users can build their own images from a specified NGC container version by using the
build-pytorch-ngcorbuild-tensorflow-ngcworkflows located in our environments
MakeFilein theenvironments repository <https://github.com/determined-ai/environments>.
There was a problem hiding this comment.
applied a commit that fixes the formatting and modifies some word choices
hkang1
approved these changes
Mar 11, 2024
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
* chore: Bumpenvs for NGC+ images * linting * this didn't need to be in here * update release notes * release notes * oops * rst is hard * Update ngc-images.rst * run rstfmt --------- Co-authored-by: Tara <tara.charter@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumpenvs for NGC+ Images (and tf2.8 removal)
determined-ai/environments#235
Test Plan
CI doesn't fail
Checklist
docs/release-notes/.See Release Note for details.
Ticket
MD-270